Skip to content

Bump LLGuidance git tag so it compiles on GCC15 #13594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

CoffeeVampir3
Copy link
Contributor

This is a small change to the common CMakeLists.txt that simply bumps the llguidance git tag to version 7.20. Without this llama cpp will fail to compile on GCC15 if building llguidance as onig_sys rust repo is deprecated. See the issue below.

guidance-ai/llguidance#173 (comment)

Copy link
Collaborator

@CISC CISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only difference between these two tags is literally just the version bump.

The issue was fixed in #13413 already, but it's better to tag an official release I guess.

@CISC CISC merged commit 3e0be1c into ggml-org:master May 16, 2025
46 checks passed
@CISC
Copy link
Collaborator

CISC commented May 16, 2025

Bah, I fumbled this one, it should have been just v0.7.20 (didn't even manage to use [no ci] correctly), oh well...

@CoffeeVampir3 CoffeeVampir3 deleted the patch-1 branch May 16, 2025 22:00
infil00p pushed a commit to baseweight/llama.cpp that referenced this pull request May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants